Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: deployment table post.go and restart.go error #1032

Merged
merged 44 commits into from
Jan 3, 2024

Conversation

claire1618
Copy link
Contributor

In my last PR for adding functionality for a new deployments database table, I added code in post.go and restart.go so that the builds field in the deployment table would be populated/updated when a deployment triggered a build.

However, I accidentally had an exception so when a deployment happened it actually skipped over this block of code.

This changes that.

@claire1618 claire1618 requested a review from a team as a code owner January 3, 2024 19:08
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a7cd07f) 66.96% compared to head (e1f4bc8) 66.96%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1032   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files         330      330           
  Lines       14074    14074           
=======================================
  Hits         9424     9424           
  Misses       4169     4169           
  Partials      481      481           
Files Coverage Δ
api/build/restart.go 0.00% <0.00%> (ø)

@claire1618 claire1618 merged commit 730b0f4 into main Jan 3, 2024
10 of 13 checks passed
@claire1618 claire1618 deleted the fix/deploymentTablePostError branch January 3, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants