Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade types and adjust tests for new build and repo fields #1013

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

ecrupper
Copy link
Contributor

A few things in this PR, none of them changing functionality:

  • Adding DB / Compiler tests for new build approved_at and approved_by fields
  • Adding DB / Compiler tests for new repo approve_build field
  • Changing types.Webhook usages to match changes here

@ecrupper ecrupper requested a review from a team as a code owner November 27, 2023 18:24
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #1013 (e079018) into main (5777666) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   68.27%   68.27%   -0.01%     
==========================================
  Files         317      317              
  Lines       13618    13617       -1     
==========================================
- Hits         9298     9297       -1     
  Misses       3853     3853              
  Partials      467      467              
Files Coverage Δ
database/build/table.go 100.00% <ø> (ø)
database/repo/table.go 100.00% <ø> (ø)
scm/github/webhook.go 85.57% <100.00%> (-0.04%) ⬇️

wass3rw3rk
wass3rw3rk previously approved these changes Nov 27, 2023
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

scm/github/webhook.go Show resolved Hide resolved
scm/github/webhook.go Outdated Show resolved Hide resolved
@ecrupper ecrupper merged commit 8de59d2 into main Nov 28, 2023
12 of 13 checks passed
@ecrupper ecrupper deleted the chore/webhook/update-struct branch November 28, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants