-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(repo): repair update name #1011
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
=======================================
Coverage 67.79% 67.79%
=======================================
Files 318 318
Lines 13754 13754
=======================================
Hits 9325 9325
Misses 3956 3956
Partials 473 473 |
5dd97f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great way to further utilize the repair API. I noted a few extra steps that will be necessary for this to work as intended. Out of scope for this PR, but I wonder if the sync
endpoint could also do something similar in these odd cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor request :disappear:
Co-authored-by: Kelly Merrick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would change the module import order in api/repo/repair.go to be closer to what it was before, but we don't currently enforce this and it's not consistent across repos either. otherwise, lgtm.
This change is to fix the Repair button under Settings. Previously, when clicking Repair button on an unarchived renamed repo and push to renamed repo, builds will not be triggered based on webhook signatures failures.
Closes #862