fixing vaders comments

go-vela · Dec 28, 2023 · 0758cb3 · 0758cb3
1 parent 0c00bcd
commit 0758cb3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/api/build/restart.go b/api/build/restart.go
@@ -339,9 +339,9 @@ func RestartBuild(c *gin.Context) {
 
 	c.JSON(http.StatusCreated, b)
 
-	d, err2 := database.FromContext(c).GetDeploymentForRepo(c, r, b.GetDeployNumber())
-	if err2 != nil {
-		logger.Errorf("unable to set get deployment for build %s: %v", entry, err2)
+	d, err := database.FromContext(c).GetDeploymentForRepo(c, r, b.GetDeployNumber())
+	if err != nil {
+		logger.Errorf("unable to set get deployment for build %s: %v", entry, err)
 	}
 
 	build := append(d.Builds, b)

diff --git a/api/deployment/get.go b/api/deployment/get.go
@@ -108,5 +108,13 @@ func GetDeployment(c *gin.Context) {
 		dep = d
 	}
 
+	if dep == nil {
+		retErr := fmt.Errorf("invalid deployment parameter provided: %s", deployment)
+
+		util.HandleError(c, http.StatusBadRequest, retErr)
+
+		return
+	}
+
 	c.JSON(http.StatusOK, dep)
 }
diff --git a/database/deployment/count_repo.go b/database/deployment/count_repo.go
@@ -10,7 +10,7 @@ import (
 	"github.com/sirupsen/logrus"
 )
 
-// CountDeploymentssForRepo gets the count of deployments by repo ID from the database.
+// CountDeploymentsForRepo gets the count of deployments by repo ID from the database.
 func (e *engine) CountDeploymentsForRepo(ctx context.Context, r *library.Repo) (int64, error) {
 	e.logger.WithFields(logrus.Fields{
 		"org":  r.GetOrg(),