feat(api/database)!: store deployment record in database for Vela-targeted deployments #5204
claire1618reviewdog.yml
on: pull_request
diff-review
1m 51s
full-review
1m 54s
Annotations
20 errors
|
diff-review:
queue/redis/redis_test.go#L95
`_steps` is unused (deadcode)
|
|
diff-review:
api/build/restart.go#L350
Error return value of `(github.com/go-vela/server/database/deployment.DeploymentInterface).UpdateDeployment` is not checked (errcheck)
|
|
diff-review:
compiler/registry/github/github.go#L41
string `/api/v3/` has 5 occurrences, make it a constant (goconst)
|
|
diff-review:
mock/server/authentication.go#L41
string `error` has 4 occurrences, make it a constant (goconst)
|
|
diff-review:
cmd/vela-server/schedule.go#L138
cyclomatic complexity 31 of func `processSchedule` is high (> 30) (gocyclo)
|
|
diff-review:
database/deployment/delete.go#L1
Actual: Copyright (c) 2022 Target Brands, Inc. All rights reserved.
|
|
diff-review:
database/deployment/deployment.go#L1
Actual: Copyright (c) 2022 Target Brands, Inc. All rights reserved.
|
|
diff-review:
database/deployment/get.go#L1
Actual: Copyright (c) 2022 Target Brands, Inc. All rights reserved.
|
|
diff-review:
database/deployment/table_test.go#L1
Actual: Copyright (c) 2023 Target Brands, Inc. All rights reserved.
|
|
diff-review:
queue/redis/route_test.go#L62
G601: Implicit memory aliasing in for loop. (gosec)
|
|
full-review:
queue/redis/redis_test.go#L95
`_steps` is unused (deadcode)
|
|
full-review:
api/build/restart.go#L350
Error return value of `(github.com/go-vela/server/database/deployment.DeploymentInterface).UpdateDeployment` is not checked (errcheck)
|
|
full-review:
mock/server/authentication.go#L41
string `error` has 4 occurrences, make it a constant (goconst)
|
|
full-review:
compiler/registry/github/github.go#L41
string `/api/v3/` has 5 occurrences, make it a constant (goconst)
|
|
full-review:
cmd/vela-server/schedule.go#L138
cyclomatic complexity 31 of func `processSchedule` is high (> 30) (gocyclo)
|
|
full-review:
database/deployment/delete.go#L1
Actual: Copyright (c) 2022 Target Brands, Inc. All rights reserved.
|
|
full-review:
database/deployment/deployment.go#L1
Actual: Copyright (c) 2022 Target Brands, Inc. All rights reserved.
|
|
full-review:
database/deployment/get.go#L1
Actual: Copyright (c) 2022 Target Brands, Inc. All rights reserved.
|
|
full-review:
database/deployment/table_test.go#L1
Actual: Copyright (c) 2023 Target Brands, Inc. All rights reserved.
|
|
full-review:
queue/redis/route_test.go#L62
G601: Implicit memory aliasing in for loop. (gosec)
|