Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add silent for defer #1879

Merged
merged 2 commits into from
Dec 7, 2024
Merged

feat: add silent for defer #1879

merged 2 commits into from
Dec 7, 2024

Conversation

danilobuerger
Copy link
Contributor

Fixes #1877

@mjpieters mjpieters mentioned this pull request Nov 5, 2024
Merged
@vmaerten vmaerten self-requested a review December 7, 2024 14:42
vmaerten
vmaerten approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@vmaerten vmaerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks !

@vmaerten vmaerten changed the title Added silent for defer feat: add silent for defer Dec 7, 2024
@vmaerten vmaerten merged commit 4595c1e into go-task:main Dec 7, 2024
14 checks passed
vmaerten added a commit that referenced this pull request Dec 7, 2024
@vmaerten
chore: changelog for #1879
cfaecf8
@danilobuerger danilobuerger deleted the silentdefer branch December 7, 2024 15:46
@vmaerten vmaerten linked an issue Dec 15, 2024 that may be closed by this pull request
defered tasks and commands cannot be silenced #1044
Closed
@vmaerten vmaerten mentioned this pull request Dec 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaerten vmaerten vmaerten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

silent on defer defered tasks and commands cannot be silenced
2 participants
@danilobuerger @vmaerten