-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reduce yaml dependencies footprint #38
Conversation
I‘ll fix the tests |
Hey, thanks for your time, dont hesitate to request review when you need ! |
@42atomys please take a look. Formatting change due to Worth noting that all tests are failing locally:
Seems that the tests are not stable regarding time zone? Makes it hard to pick up the actual errors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Thanks for your contribution and help us to follow the directives of "reducing dependencies" 💜
Description
Noticed that k8s suddenly appeared in my dependencies. Since this only adds yaml2json features it's not necessary here.
Changes
Checklist
Additional Information
Follow-up to #36