Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce yaml dependencies footprint #38

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Conversation

andig
Copy link

@andig andig commented Jun 10, 2024

Description

Noticed that k8s suddenly appeared in my dependencies. Since this only adds yaml2json features it's not necessary here.

Changes

  • Replace sigs yaml deps by go-yaml

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • This change requires a change to the documentation on the website.

Additional Information

Follow-up to #36

@42atomys 42atomys added type/chore 🛠 Code changes that neither fix bugs nor add features (refactoring, dependency changes, ...) priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed aspect/depencencies 📦️ Concerns dependencies of the project domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously labels Jun 10, 2024
@42atomys 42atomys changed the title Trim dependencies chore: reduce yaml dependencies footprint Jun 10, 2024
@andig
Copy link
Author

andig commented Jun 10, 2024

I‘ll fix the tests

@42atomys
Copy link
Member

Hey, thanks for your time, dont hesitate to request review when you need !

@andig
Copy link
Author

andig commented Jun 11, 2024

@42atomys please take a look. Formatting change due to gofmt.

Worth noting that all tests are failing locally:

--- FAIL: TestMustToDate (0.00s)
    --- FAIL: TestMustToDate/TestDate (0.00s)
        conversion_functions_test.go:143:
            	Error Trace:	/Users/andig/htdocs/sprout/test_helpers_test.go:57
            	Error:      	Not equal:
            	            	expected: "time.Time-2024-05-09 00:00:00 +0000 UTC"
            	            	actual  : "time.Time-2024-05-09 00:00:00 +0200 CEST"

Seems that the tests are not stable regarding time zone? Makes it hard to pick up the actual errors.

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
encoding_functions.go 96.9% <100.0%> (-3.1%) ⬇️

@42atomys
Copy link
Member

@andig I will takes a look to resolve the time zone leaking 💧 by opening an issue to track that (#41)

Copy link
Member

@42atomys 42atomys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Thanks for your contribution and help us to follow the directives of "reducing dependencies" 💜

@42atomys 42atomys merged commit 4ea0e87 into go-sprout:main Jun 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect/depencencies 📦️ Concerns dependencies of the project domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed type/chore 🛠 Code changes that neither fix bugs nor add features (refactoring, dependency changes, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants