Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support entire 2xx HTTP status range for webhooks #15

Merged
merged 4 commits into from
Sep 27, 2024
Merged

feat: Support entire 2xx HTTP status range for webhooks #15

merged 4 commits into from
Sep 27, 2024

Conversation

timo-reymann
Copy link
Contributor

Fixes #14

@timo-reymann timo-reymann mentioned this pull request Sep 10, 2024
Closed
@coveralls
Copy link

coveralls commented Sep 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11048472669

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.721%
Totals Coverage Status
Change from base Build 10657995583: 0.0%
Covered Lines: 472
Relevant Lines: 488
💛 - Coveralls

paskal
paskal requested changes Sep 21, 2024
View reviewed changes
webhook.go Outdated Show resolved Hide resolved
@timo-reymann timo-reymann requested a review from paskal September 23, 2024 09:04
paskal
paskal approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@paskal paskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@timo-reymann timo-reymann requested a review from paskal September 27, 2024 11:09
paskal
paskal approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@paskal paskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umputun please squash on merge instead of rebasing.

@umputun umputun merged commit a5912bd into go-pkgz:master Sep 27, 2024
1 check passed
@timo-reymann timo-reymann deleted the feat/support-entire-2xx-range-webhook branch September 28, 2024 10:27
@paskal
Copy link
Collaborator

paskal commented Sep 30, 2024

@timo-reymann your change is released as v1.2.0

@timo-reymann
Copy link
Contributor Author

Thank you! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paskal paskal paskal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow any 2xx status for webhooks
4 participants
@timo-reymann @coveralls @paskal @umputun