export KeyRSA and KeyEd25519 #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is intentional. crypto.PrivateKey is supposed to be type cased to crypto.Signer and crypto.Decrypter as those methods are needed. Since that's supported, the implementations aren't exported |
|
Thank you! I did that and it worked, I added a pr for the readme #165 if you think that's useful for others |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
keyRSAandkeyEd25519are supposed to be Public types but aren't exported because of their lowercase name. Here's a PR to fix it. I had to change it to getpiv-goworking with my yubikey with RSA2048 keys.