Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code button alignment #33345

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix code button alignment #33345

merged 2 commits into from
Jan 22, 2025

Conversation

silverwind
Copy link
Member

Fixes: #33344

Before:
Screenshot 2025-01-22 at 00 40 03

After:
Screenshot 2025-01-22 at 00 39 51

SVGs should not be put into <span> as this messes with the parent flexbox alignment.

BTW the string "Code" is not translated. Maybe for another PR to keep this backportable.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 21, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2025
@silverwind silverwind added the backport/v1.23 This PR should be backported to Gitea 1.23 label Jan 21, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 21, 2025
@silverwind silverwind added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI and removed modifies/templates This PR modifies the template files labels Jan 21, 2025
@silverwind silverwind mentioned this pull request Jan 21, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 22, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 22, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 22, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 22, 2025 02:00
@wxiaoguang wxiaoguang merged commit abe743d into go-gitea:main Jan 22, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 22, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 22, 2025
@silverwind @wxiaoguang @GiteaBot
Fix code button alignment (go-gitea#33345)
ccbace7 
Fixes: go-gitea#33344

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot mentioned this pull request Jan 22, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jan 22, 2025
wxiaoguang added a commit that referenced this pull request Jan 22, 2025
@GiteaBot @silverwind @wxiaoguang
Fix code button alignment (#33345) (#33351)
e08eed9 
Backport #33345 by silverwind

Co-authored-by: silverwind <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@silverwind silverwind deleted the codebtn branch January 22, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Minor misalignment with Code button on source pages
5 participants
@silverwind @techknowlogick @wxiaoguang @a1012112796 @GiteaBot