Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial fixes #33304

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Trivial fixes #33304

merged 7 commits into from
Jan 17, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 16, 2025

  1. the error check was added for go-git, it was caused by the empty .keep file in the test fixtures.
  2. use PostFormValue instead of PostForm.Get (Get needs to parse the form ahead)
  3. fix incorrect container text (it should show "Images" in the header but not "OS/Arch")
  4. align maven xml

image

  1. fix closed PR color&icon

image

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 16, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2025
@wxiaoguang wxiaoguang marked this pull request as draft January 16, 2025 14:29
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 16, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 16, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 16, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 16, 2025
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2025
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2025
@wxiaoguang wxiaoguang marked this pull request as ready for review January 16, 2025 15:28
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 16, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 17, 2025 08:29
@wxiaoguang wxiaoguang merged commit 3b839f8 into go-gitea:main Jan 17, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-misc branch January 17, 2025 08:55
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Jan 17, 2025
1. the error check was added for go-git, it was caused by the empty `.keep` file in the test fixtures.
2. use `PostFormValue` instead of `PostForm.Get` (`Get` needs to parse the form ahead)
3. fix incorrect container text (it should show "Images" in the header but not "OS/Arch")
4. align maven xml
5. fix closed PR color&icon
# Conflicts:
#	templates/shared/issueicon.tmpl
lunny pushed a commit that referenced this pull request Jan 17, 2025
Backport #33304

The only conflict is caused by `templates/shared/issueicon.tmpl`
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 20, 2025
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix typo in documentation of GetBranchNames() (go-gitea#33330)
  Fix Account linking page (go-gitea#33325)
  Fix parentCommit invalid memory address or nil pointer dereference. (go-gitea#33204)
  Make tracked time representation display as hours (go-gitea#33315)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Fix push message behavior (go-gitea#33215)
  Add golang back to nix dev environment and pin v1.23 (go-gitea#33275)
  Trivial fixes (go-gitea#33304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants