-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trivial fixes #33304
Merged
Merged
Trivial fixes #33304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jan 16, 2025
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Jan 16, 2025
wxiaoguang
added
the
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
label
Jan 16, 2025
github-actions
bot
added
the
modifies/templates
This PR modifies the template files
label
Jan 16, 2025
pull-request-size
bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jan 16, 2025
pull-request-size
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Jan 16, 2025
lunny
approved these changes
Jan 16, 2025
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jan 16, 2025
silverwind
reviewed
Jan 16, 2025
silverwind
approved these changes
Jan 17, 2025
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jan 17, 2025
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Jan 17, 2025
1. the error check was added for go-git, it was caused by the empty `.keep` file in the test fixtures. 2. use `PostFormValue` instead of `PostForm.Get` (`Get` needs to parse the form ahead) 3. fix incorrect container text (it should show "Images" in the header but not "OS/Arch") 4. align maven xml 5. fix closed PR color&icon # Conflicts: # templates/shared/issueicon.tmpl
lunny
pushed a commit
that referenced
this pull request
Jan 17, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 20, 2025
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix typo in documentation of GetBranchNames() (go-gitea#33330) Fix Account linking page (go-gitea#33325) Fix parentCommit invalid memory address or nil pointer dereference. (go-gitea#33204) Make tracked time representation display as hours (go-gitea#33315) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Fix push message behavior (go-gitea#33215) Add golang back to nix dev environment and pin v1.23 (go-gitea#33275) Trivial fixes (go-gitea#33304)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/frontend
modifies/go
Pull requests that update Go code
modifies/templates
This PR modifies the template files
modifies/translation
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.keep
file in the test fixtures.PostFormValue
instead ofPostForm.Get
(Get
needs to parse the form ahead)