fix: path parsing issue 2 #379
Conversation
|
gm @ccoVeille kindly review :) |
| // Add middleware to strip trailing slash from requests | ||
| stripSlashMiddleware := func(next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if len(r.URL.Path) > 1 { | ||
| r.URL.Path = strings.TrimRight(r.URL.Path, "/") | ||
| } | ||
| next.ServeHTTP(w, r) | ||
| }) | ||
| } |
There was a problem hiding this comment.
Please do not re-define this middleware each time the option is called. Place the middleware elsewhere :) Also, I think the middleware should be placed in Server.globalMiddlewares, see the difference in the docs.
server.go
Outdated
| // WithStripTrailingSlash enables stripping of trailing slashes from routes and requests | ||
| // Default is false. | ||
| // | ||
| // Example: | ||
| // | ||
| // app := fuego.NewServer( | ||
| // fuego.WithStripTrailingSlash(), | ||
| // ) | ||
| func WithStripTrailingSlash() func(*Server) { | ||
| return func(s *Server) { | ||
| // Add OptionStripTrailingSlash to the default route options | ||
| s.routeOptions = append(s.routeOptions, OptionStripTrailingSlash()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Very good! With one Server Option, they will be able to have this feature :)
I think it should look like this:
s.routeOptions = append(s.routeOptions, OptionStripTrailingSlash())
s.globalMiddlewares = append(s.globalMiddlewares, stripTrailingSlashesMiddleware)
|
kindly review @EwenQuim |
|
Edited title so I don't keep getting confused 😄 |
|
😅 |
mmmh 🤔 Also, what about this comment and this one ? Seems that it wasn't really ready lol ;) |
closes #366