Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare custom 200 response #251

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

EwenQuim
Copy link
Member

@EwenQuim EwenQuim commented Dec 5, 2024

No description provided.

@dylanhitt
Copy link
Collaborator

Is the intention for this to cover #222 ?

@EwenQuim
Copy link
Member Author

EwenQuim commented Dec 5, 2024

It's not the initial intention but yeah it adds more flexibility, useful for use cases where the user want to declare its own content-types, types, etc...

Adding the ability to override the framework is a must-have: the framework must be an enabler, not a blocker!

@EwenQuim EwenQuim force-pushed the only-declare-200-if-not-exists branch from 949f1c6 to 94d31fb Compare December 5, 2024 17:30
Copy link
Collaborator

@dylanhitt dylanhitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so it relates to #222 and #247. I am gonna take a crack at updating WithGlobalResponseTypes for the error part of this.

Cheers

@EwenQuim EwenQuim merged commit bb60ad5 into main Dec 5, 2024
5 checks passed
@EwenQuim EwenQuim deleted the only-declare-200-if-not-exists branch December 5, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants