Enable more golangci linters

.golangci.yml

@@ -1,6 +1,14 @@
 linters:
   enable:
+    - errcheck
     - errorlint
     - gofmt
+    - gosimple
+    - govet
+    - ineffassign
+    - misspell
+    - revive
+    - staticcheck
     - stylecheck
+    - unused
     - whitespace

backend_qemu.go

@@ -51,7 +51,7 @@ var qemuMachines = map[Arch]qemuMachine{
 		binary:  "qemu-system-aarch64",
 		console: "ttyAMA0",
 		machine: "virt",
-		/* The default cpu is a 32 bit one, which isn't very usefull
+		/* The default cpu is a 32 bit one, which isn't very useful
 		 * for 64 bit arm. There is no cpu setting for "minimal" 64
 		 * bit linux capable processor. The only generic setting
 		 * is "max", but that can be very slow to emulate. So pick
@@ -174,7 +174,7 @@ func (b qemuBackend) JobOutputTTY() string {
 	return "/dev/hvc0"
 }
 
-func (b qemuBackend) MountParameters(mount mountPoint) (string, []string) {
+func (b qemuBackend) MountParameters(_ mountPoint) (string, []string) {
 	return "9p", []string{"trans=virtio", "version=9p2000.L", "cache=loose", "msize=262144"}
 }
 

cmd/fakemachine/main.go

@@ -146,9 +146,8 @@ func main() {
 		var flagsErr *flags.Error
 		if errors.As(err, &flagsErr) && flagsErr.Type == flags.ErrHelp {
 			os.Exit(0)
-		} else {
-			os.Exit(1)
 		}
+		os.Exit(1)
 	}
 
 	m, err := fakemachine.NewMachineWithBackend(options.Backend)

decompressors_test.go

@@ -39,7 +39,7 @@ func checkStreamsMatch(t *testing.T, output, check io.Reader) error {
 				i, ochar, cchar)
 			return errors.New("Data mismatch")
 		}
-		i += 1
+		i++
 	}
 }
 

machine.go

@@ -240,7 +240,7 @@ func NewMachineWithBackend(backendName string) (*Machine, error) {
 		m.AddVolume("/etc/ssl")
 	}
 
-	// Mounts for java VM configuration, especialy security policies
+	// Mounts for java VM configuration, especially security policies
 	matches, _ := filepath.Glob("/etc/java*")
 	for _, path := range matches {
 		stat, err := os.Stat(path)
@@ -566,7 +566,7 @@ func (m *Machine) generateModulesDep(w *writerhelper.WriterHelper, moddir string
 			deps[j] = deppath
 		}
 		output[i] = fmt.Sprintf("%s: %s", modpath, strings.Join(deps, " "))
-		i += 1
+		i++
 	}
 
 	path := path.Join(moddir, "modules.dep")