actions/image-partition: truncate filesystem label to maximum supported length #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
approved these changes
Jan 28, 2025
…ed length
Added optional fslabel property to partition to allow truncation of filesystem
label and allow user to modify filesystem label without modifying the name.
Filesystem label defaults to the name property of the partition.
The filesystem label can be up to 11 characters long for {v}fat{12|16|32},
16 characters long for ext2/3/4, 255 characters long for btrfs, 512 characters
long for hfs/hfsplus and 12 characters long for xfs.
Fixes: go-debos#251
Suggested-by: Christopher Obbard <[email protected]>
Signed-off-by: Vignesh Raman <[email protected]>
Signed-off-by: Dylan Aïssi <[email protected]>
daissi
force-pushed
the
vigneshraman/debos/issues/251-v1
branch
from
d31c1c2 to
2b9ada8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional fslabel property to partition to allow truncation of filesystem
label and allow user to modify filesystem label without modifying the name.
Filesystem label defaults to the name property of the partition.
The filesystem label can be up to 11 characters long for vfat, 16 characters
long for ext2/3/4, 255 characters long for btrfs, 512 characters long for
hfs/hfsplus and 12 characters long for xfs.
Fixes: #251
Suggested-by: Christopher Obbard [email protected]
Signed-off-by: Vignesh Raman [email protected]
Signed-off-by: Dylan Aïssi [email protected]
This MR is based on @vigneshraman 's work from #271.