Install .desktop file and SVG icon on Linux #1142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVGs have had a great support for Linux for about a decade, so only install that for simplicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR competes with #1011. That was an attempt to ship a .desktop file and icon on Linux which got stalled.
This resolves the stall by only installing the SVG icon, which have had great support on Linux for about a decade.
Gnome Boxes is examples of another KVM app on Linux that only ships an SVG icon.
Because Looking Glass doesn't ship a desktop or icon on Linux, some people are creating their own and in some cases have wrongly selected the ~2500x2500 PNG logo file as their choice, accidentally slowing down their system as their desktop system works to downscale the huge PNG to a reasonable size.
See: https://codeberg.org/dnkl/fuzzel/issues/306
Shipping a proper icon will resolve that.
This also provides two other improvements over #1011: