Add a parameter to hide the waiting message in the GUI #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnif
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Looks good, a few changes to be made though.
Also please be sure to add yourself to the AUTHORS file, and update the documentation with the new parameter.
Please also fix your commit message to follow the standard this project uses, for example:
[client] app: add option to disable the waiting for host message
RodoMa92
force-pushed
the
feat_hide_waiting_gui_option
branch
from
1ded9f3 to
354be42
Compare
RodoMa92
force-pushed
the
feat_hide_waiting_gui_option
branch
from
354be42 to
79264a4
Compare
|
It should be all good to go, now. Let me know if you need additional changes merged here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small change to hide the popup messagebox in the UI while waiting.