Code

Vertical Cursor Guide#383

Code

Open

ahelsley wants to merge 32 commits intognachman:mastergnachman/iTerm2:masterfrom ahelsley:vertical-cursor-guideahelsley/iTerm2:vertical-cursor-guideCopy head branch name to clipboard

+547-65

Commits

Commits on Mar 26, 2019

• Render a vertical guide over the column the cursor is in (Metal View implementation).

  

  Andrew Helsley

  committed
  68e3d2e

• Separate control of the vertical cursor guide from the horizontal guide.

  

  Andrew Helsley

  committed
  6827cb3

• Render a vertical cursor guide in the software rendered view (known issue: only renders on the 3 lines centered on the cursor).

  

  Andrew Helsley

  committed
  ed11a8e

• Fill out cursor column tracking API.

  

  Andrew Helsley

  committed
  51d1fed

Commits on Apr 2, 2019

• Fix names and style inconsistencies.

  

  Andrew Helsley

  committed
  5b8119b

• Rename a couple more "col" variables to use full names.

  

  Andrew Helsley

  committed
  1b12bae

• Fix bug with variable name type ("...Line" should be "...Column"). Renamve vvertexBuffer into verticalGuideVertexBuffer. Finish separating out control over the horizontal cursor guide from the vert…

  Show description for 59f1be9
  

  Andrew Helsley

  committed
  59f1be9

Commits on Apr 7, 2019

• Remove extraneous shared vertex buffer in favor of keeping more in the cursor guide renderer. Create additional texture for vertical cursor guide. Create additional vertex buffers for vertical and …

  Show description for 683f718
  

  Andrew Helsley

  committed
  683f718

• Remove bad boolean checks.

  

  Andrew Helsley

  committed
  7af2a50

• Use bounds from iTermCursorGuideRendererTransientState's cellConfiguration instead of requiring them to be passed into the method.

  

  Andrew Helsley

  committed
  c8743a8

• Since [...textView setNeedsDisplayOnColumn...] is expensive (causes a complete redraw), do not cause the redraw unless there is good reason to do so (ie the vertical cursor guide is enabled).

  

  Andrew Helsley

  committed
  1706bf1

• Factor out rectangle tessellation and vertex buffer creation.

  

  Andrew Helsley

  committed
  933ed96

Commits on Apr 8, 2019

• Do not double-draw the cursor guide under the cursor.

  

  Andrew Helsley

  committed
  7540e63

Commits on Apr 13, 2019

• Render a vertical guide over the column the cursor is in (Metal View implementation).

  

  Andrew Helsley

  committed
  b7b9430

• Separate control of the vertical cursor guide from the horizontal guide.

  

  Andrew Helsley

  committed
  516e4bb

• Render a vertical cursor guide in the software rendered view.

  

  Andrew Helsley

  committed
  e99e660

• Fill out cursor column tracking API.

  

  Andrew Helsley

  committed
  139103b

• Fix bug with variable name type ("...Line" should be "...Column"). Renamve vvertexBuffer into verticalGuideVertexBuffer. Finish separating out control over the horizontal cursor guide from the vert…

  Show description for 025b02b
  

  Andrew Helsley

  committed
  025b02b

• Remove extraneous shared vertex buffer in favor of keeping more in the cursor guide renderer. Create additional texture for vertical cursor guide. Create additional vertex buffers for vertical and …

  Show description for 921b5cf
  

  Andrew Helsley

  committed
  921b5cf

• Factor out rectangle tessellation and vertex buffer creation.

  

  Andrew Helsley

  committed
  cd25d8c

• Use bounds from iTermCursorGuideRendererTransientState's cellConfiguration instead of requiring them to be passed into the method.

  

  Andrew Helsley

  committed
  bdbe918

• Since [...textView setNeedsDisplayOnColumn...] is expensive (causes a complete redraw), do not cause the redraw unless there is good reason to do so (ie the vertical cursor guide is enabled).

  

  Andrew Helsley

  committed
  48a48cc

• Do not double-draw the cursor guide under the cursor.

  

  Andrew Helsley

  committed
  262e707

• Fix style nits.

  

  Andrew Helsley

  committed
  64bf5c4

• Fix rebase conflict.

  

  Andrew Helsley

  committed
  7c6142d

• Resolved conflicts with upstream branch.

  

  Andrew Helsley

  committed
  a0bb3d5

• Remove merge/conflict resolution detritus.

  

  Andrew Helsley

  committed
  1618e45

• Remove unused variable that seems to be causing CI build fails.

  

  Andrew Helsley

  committed
  7f4a4a4

Commits on Apr 18, 2019

• Add ability to render a vertical guide over the column the cursor is in.

  

  Andrew Helsley

  committed
  18c8e57

• Merged with upstream branch

  

  Andrew Helsley

  committed
  c12ee73

• Remove code duplicated as a result of merge with upstream branch.

  

  Andrew Helsley

  committed
  66cf560

• Disable code that references an undeclared identifier (brought in from master/HEAD during rebase?).

  

  Andrew Helsley

  committed
  ed738eb