Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set $ITERM2_COPROCESS env var inside coprocesses #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rolandwalker
Copy link
Contributor

It might be nice for coprocesses to be able to detect that they are being run in that environment.
This patch sets an environment variable $ITERM2_COPROCESS.
The value might as well hold something useful: ttyname() from the originating interactive terminal.

Coprocess.m Outdated
@@ -72,6 +73,7 @@ + (Coprocess *)launchedCoprocessWithCommand:(NSString *)command
}
}

setenv("ITERM2_COPROCESS", [tty UTF8String], 1);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it ITERM2_COPROCESS_TTY so its meaning is clear.

the value holds ttyname() from the originating interactive terminal
@rolandwalker
Copy link
Contributor Author

I noticed this old PR, squashed and rebased it.

@gnachman
Copy link
Owner

Sadly, it is not safe to call setenv() between fork and exec. Only the functions listed in the sigaction man page in the "NOTE" section may be called. In practice, this means using execle() instead of execl() when you want to set an environment variable.

The reason is that in a multithreaded program (which we are) another thread might have a mutex locked at the time of fork() (specifically, a mutex owned by libc). In the child process, that mutex will be locked forever since the child process only gets a single thread (the one where fork was called). The call to setenv() acquires a mutex, and will deadlock in this case.

@rolandwalker
Copy link
Contributor Author

So the correct implementation would

  • memcpy global environ before forking
  • manually add a pointer to "ITERM2_COPROCESS_TTY=blah" to the copy
  • defend against the corner case where $ITERM2_COPROCESS_TTY was already set
  • execle with the copy

@gnachman
Copy link
Owner

I think that's right. Let's call it ITERM2_COPROCESS so we can add more info to it if desired later on (like profile name, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants