-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake build config #3
Conversation
Not to get into a compilation system war, but is there a compelling reason to use CMake that Autotools does not cover? It is a relatively simple project, I am more used to Autotools and don't yet see a clear benefit to switching. The proposed CMakelists.txt does not generate the |
Now cmake is full available. |
That looks more promising. I changed the base to branch
|
An exists issue #409 |
It seems to compile and run the test properly, and I should merge that PR. I have one more request: although I did ask to be able to run the tests, can the dependency on |
Yes, gtest is optional, you can turn off the build of tests by passing -DNOSHELL_BUILD_TESTS=OFF to cmake, for example |
Thank you for the PR. I merged it. It will appear in the next version. |
No description provided.