Fix issue #72 (Prompt for confirmation before exiting dialog) #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #72.
The confirmation popup is shown in some cases where I don't think it's necessary. If the user adds occlusions, clicks on one of the buttons to create the cards and then closes the editor dialog they are
![image](https://user-images.githubusercontent.com/12101162/71764376-64b30b80-2ee7-11ea-834f-0ae278772eb9.png)
prompted for confirmation.
The only way I can think of to prevent this is to reset the svg-edit undo stack when the user clicks on the button, but I'm not sure if that's acceptable.
I changed the way the popup opens from directly calling the constructor to opening it via
aqt.dialogs.open(...)
so it behaves more like the other dialogs in Anki.I used the
askUser(...)
function fromaqt.utils
to show the popup as you can see in the following screenshot:Checklist: