Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure key is a Constant. #65

Closed
wants to merge 1 commit into from
Closed

Ensure key is a Constant. #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion logging_format/visitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from ast import (
Add,
Call,
Constant,
keyword,
iter_child_nodes,
Mod,
Expand Down Expand Up @@ -147,7 +148,7 @@ def visit_Dict(self, node):
if self.should_check_extra_field_clash(node):
for key in node.keys:
# key can be None if the dict uses double star syntax
if key is not None and key.s in RESERVED_ATTRS:
if key is not None and isinstance(key, Constant) and key.s in RESERVED_ATTRS:
self.violations.append((self.current_logging_call, EXTRA_ATTR_CLASH_VIOLATION.format(key.s)))

if self.should_check_extra_exception(node):
Expand Down