Output fractional seconds in timestamp.to_rfc3339 function
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `to_rfc3339` prints fractional seconds, allow generating timestamps with non-zero nanoseconds for round-trip tests.
|
Original issue: #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output fractional seconds in
timestamp.to_rfc3339function.I figured it may be best to avoid a method that divides the nanoseconds by 1 billion, then converts that float to a string using
float.to_string, so that we can fully control the format. (E.g., it won't depend on any changes to how stdlib prints float strings or anything else like that.) And so, it uses that "digit arithmetic" method that you see.Additionally, I mentioned needing to update some of the round-trip tests once the fractional seconds are printed by
timestamp.to_rfc3339. This PR includes those test updates as well.