Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix year padding in to_rfc3339 #10

Closed
wants to merge 1 commit into from
Closed

Fix year padding in to_rfc3339 #10

wants to merge 1 commit into from

Conversation

mooreryan
Copy link
Contributor

@mooreryan mooreryan commented Jan 9, 2025 •
edited
Loading

Code and tests to address the year padding issue: #7 (comment)

lpil
lpil approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@mooreryan mooreryan marked this pull request as draft January 11, 2025 06:46
@mooreryan mooreryan mentioned this pull request Jan 11, 2025
Merged
@mooreryan
Copy link
Contributor Author

I needed to cherry pick the commit from this PR for #12. I switched this to draft temporarily -- if #12 is accepted, this one should be closed. If #12 is not accepted, this one should stay.

@lpil
Copy link
Member

lpil commented Jan 20, 2025

Thank you!

@lpil lpil closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mooreryan @lpil