Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Small changes #60

wants to merge 4 commits into from

Conversation

afcady
Copy link

@afcady afcady commented Aug 19, 2020

I wrote a few commits, that don't change very much, but are improvements.

Thanks for creating tuntox.

Andrew Cady added 3 commits August 19, 2020 01:29
This produced a nonsensical warning in client mode.

It is also redundant as there is this line:

log_printf(L_INFO, "Server in ToxID whitelisting mode - only clients listed with -i can connect");
The client and server blocks were nearly identical.  Now they share code.

Both client and server now call memset() on tox_printable_id.

The distinct client message "Generated Tox ID: %s\n" was not preserved;
both client and server will say "Using Tox ID: %s\n" which is more
accurate (Tox ID might be persistent with -C).
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gjedeer
Copy link
Owner

gjedeer commented Aug 19, 2020

Alright, will test and merge.

I don't like removing the debug printf - if you don't like it, don't run with -d?

@afcady
Copy link
Author

afcady commented Aug 19, 2020

To be clear: I removed it because (1) it's inaccurate -- it says something about "server" when in client mode; and (2) it's redundant -- the other debug printf triggers in exactly the same conditions; not because I don't like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants