Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modification function broadcast_shape #395

Merged
merged 1 commit into from
Oct 24, 2023
Merged

modification function broadcast_shape #395

merged 1 commit into from
Oct 24, 2023

Conversation

chachaleo
Copy link
Contributor

Pull Request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #393

raphaelDkhn
raphaelDkhn approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@raphaelDkhn raphaelDkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @chachaleo

@raphaelDkhn raphaelDkhn merged commit 9e9fd37 into gizatechxyz:main Oct 24, 2023
1 check passed
@raphaelDkhn
Copy link
Collaborator

@all-contributors add @chachaleo for code

@allcontributors allcontributors bot mentioned this pull request Oct 24, 2023
Merged
@allcontributors
Copy link
Contributor

@raphaelDkhn

I've put up a pull request to add @chachaleo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelDkhn raphaelDkhn raphaelDkhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev: unnecessary reverse in broadcast_shape
2 participants
@chachaleo @raphaelDkhn