Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: neg operator #388

Merged
merged 10 commits into from
Oct 24, 2023
Merged

feat: neg operator #388

merged 10 commits into from
Oct 24, 2023

Conversation

0x73e
Copy link
Contributor

@0x73e 0x73e commented Oct 23, 2023

Pull Request type

Closes #362

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Missing Neg operator.

Issue Number: N/A

What is the new behavior?

Implements Neg operator.

  • Implemented Neg operator

Does this introduce a breaking change?

  • Yes
  • No

Other information

@0x73e
Copy link
Contributor Author

0x73e commented Oct 23, 2023

@raphaelDkhn I couldn't find any contribution guidelines in the repo. Please let me know if any docs/linting/tests, etc need to be done before PR is merged. Thanks

@raphaelDkhn
Copy link
Collaborator

raphaelDkhn commented Oct 23, 2023

@raphaelDkhn I couldn't find any contribution guidelines in the repo. Please let me know if any docs/linting/tests, etc need to be done before PR is merged. Thanks

Thanks @0x73e, I will review later today. Here is the contribution guideline. Here you can find a step-by-step tuto to contribute to Orion. If I see anything missing during my review, I let you know :)

@0x73e
Copy link
Contributor Author

0x73e commented Oct 23, 2023

Thanks, totally missed this

@0x73e 0x73e changed the base branch from main to develop October 23, 2023 13:38
@raphaelDkhn
Copy link
Collaborator

LGTM! Good first PR @0x73e thanks!

Just three small things that was missing:

@raphaelDkhn raphaelDkhn merged commit 4db8a55 into gizatechxyz:develop Oct 24, 2023
1 check passed
@raphaelDkhn
Copy link
Collaborator

@all-contributors add @0x73e for code

@allcontributors
Copy link
Contributor

@raphaelDkhn

I've put up a pull request to add @0x73e! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Neg
2 participants