Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we pass auth_pass to avoid NOAUTH Authentication required #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure we pass auth_pass to avoid NOAUTH Authentication required #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,12 @@ RedisSentinelClient.prototype._connectSentinel = function (port, host) {
// one client to query ('talker'), one client to subscribe ('listener').
// these are standard redis clients.
// talker is used by reconnect() below
this.sentinelTalker = new RedisSingleClient.createClient(port, host);

// Ensure we pass the options on Create Client functionality.
// This way if we have passed auth_pass it would be picked up and
// the error "Ready check failed: NOAUTH Authentication required." should not appear
// if auth_pass is configured
var sentinelListener = new RedisSingleClient.createClient(port, host, this.options);
this.sentinelTalker.on('connect', function(){
debug('connected to sentinel talker at ' + host + ':' + port);
self.emit('sentinel connected', [host,port])
Expand All @@ -142,7 +147,11 @@ RedisSentinelClient.prototype._connectSentinel = function (port, host) {
}
});

var sentinelListener = new RedisSingleClient.createClient(port, host);
// Ensure we pass the options on Create Client functionality.
// This way if we have passed auth_pass it would be picked up and
// the error "Ready check failed: NOAUTH Authentication required." should not appear
// if auth_pass is configured
var sentinelListener = new RedisSingleClient.createClient(port, host, this.options);
this.sentinelListener = sentinelListener;
sentinelListener.on('connect', function(){
debug('connected to sentinel listener at ' + host + ':' + port);
Expand Down