Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Introduce prettier-eslint and upgrade eslint related packages #882

Merged
merged 11 commits into from
Jun 22, 2019

Conversation

chinesedfan
Copy link
Member

@chinesedfan chinesedfan commented Jun 21, 2019

Enhanced from #875.

  • Introduced prettier-eslint.
  • Upgraded to eslint@5 and related packages. Notice eslint-import-resolver-babel-module requires babel@7, so it and its peer dependency babel-plugin-module-resolver are kept the same.
  • In order to not change too many codes, prettier is locked too. And some eslint rules are updated or turned off temporarily.
  • .eslintrc is replaced by .eslintrc.js as it is recommended to deprecate the non-extension configuration file.

Tips,

  • Double asterisks are only useful in Bash >=4 with globstar option on.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.688% when pulling b370d14 on chinesedfan:prettier-eslint into a2aa221 on gitpoint:master.

@chinesedfan chinesedfan merged commit 6427433 into gitpoint:master Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants