Update nav.html

[Ayush277]

Using unless makes the condition slightly more readable by directly expressing the condition for the exception. In this case, we want to render the breadcrumb unless the layout is 'index', which reads more naturally and reduces cognitive load compared to checking if the layout is not 'index'. This refactor does not alter the behavior of the code but enhances its clarity and maintainability.

[jmeridth]

@Ayush277 thank you for the PR. Looks like we need to switch from endif to endunless to pass CI.

In my personal opinion, I do not think unless is more readable. I think it causes more confusion because we have to negate in our heads instead of explicit !=. But that is a religious argument between rubyists and non-rubyists. 😉 Since we're using liquid for the templates, I get it.

I will ping the other maintainers and get some reviews on this. Again, thank you for the contribution.

[Satishmirjan]

assign me this , i already solved similar problems.

[jmeridth]

assign me this , i already solved similar problems.

This is a pull request, already assigned/owned. Thank you though.

[kenyonj]

@Ayush277 thank you for the PR. Looks like we need to switch from endif to endunless to pass CI.

In my personal opinion, I do not think unless is more readable. I think it causes more confusion because we have to negate in our heads instead of explicit !=. But that is a religious argument between rubyists and non-rubyists. 😉 Since we're using liquid for the templates, I get it.

I will ping the other maintainers and get some reviews on this. Again, thank you for the contribution.

I agree.

For me, this is more readable:
If the condition is not true, then do your thing
than this:
Unless the condition is true, then do your thing

It always takes me a 🤌 little bit more to figure out if I fall into the condition funnel with the unless

[jmeridth]

Thank you for consensus @kenyonj @tomthorogood. Please continue to contribute @Ayush277 🙇