Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a resource #3231

Closed
wants to merge 8 commits into from
Closed

Adding a resource #3231

wants to merge 8 commits into from

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented May 26, 2024

Purpose

This PR adds a link from a section in OpenSauced's Maintainer course to the Building Community chapter. This resource would help new open source maintainers learn more ways to building and facilitating communities for their open source project.

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


@CBID2 CBID2 requested a review from a team as a code owner May 26, 2024 17:14
@CBID2 CBID2 temporarily deployed to Pages Preview May 26, 2024 17:15 — with GitHub Actions Inactive
@CBID2 CBID2 temporarily deployed to Pages Preview May 26, 2024 17:17 — with GitHub Actions Inactive
@CBID2 CBID2 temporarily deployed to Pages Preview June 2, 2024 16:43 — with GitHub Actions Inactive
Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title was removed and the new link 404s. Added comments.

@@ -204,6 +204,7 @@ redirect_from: /zh-tw/how-to-contribute/

* [GitHub 探索](https://github.com/explore/)
* [First Timers Only](http://www.firsttimersonly.com/)
* [你的第一個 PR](https://yourfirstpr.github.io/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link 404s

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need removed

@@ -1,6 +1,6 @@
---
lang: en
title: Building Welcoming Communities
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove the title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -273,4 +273,4 @@ Your tiebreaker should be a last resort. Divisive issues are an opportunity for

## Community is the ❤️ of open source

Healthy, thriving communities fuel the thousands of hours poured into open source every week. Many contributors point to other people as the reason for working - or not working - on open source. By learning how to tap into that power constructively, you'll help someone out there have an unforgettable open source experience.
Healthy, thriving communities fuel the thousands of hours poured into open source every week. Many contributors point to other people as the reason for working - or not working - on open source. By learning how to tap into that power constructively, you'll help someone out there have an unforgettable open source experience. If you're looking for more ways to build your open source community, check out the chapter ["Building and Nurturing a Welcoming and Supportive Community" in OpenSauced's "Becoming a Maintainer" course](https://intro.opensauced.pizza/#/becoming-a-maintainer/building-community?id=building-and-nurturing-a-welcoming-and-supportive-community).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to link to a whole other guide. This is being discussed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I may @jmeridth, I have not seen most materials on becoming an open source maintainer presented in a structured way before, and I think alot of people can benefit from it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our guide does that. I'll get an answer on this tomorrow and let you know. Thank you for your patience.

Copy link

@Emadalshamery Emadalshamery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

تقديم ملاحظات

Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at the commits on this PR and your change, I think your PR consists of commits you didn't make and they have caused unforeseen changes (missing title, 404 link).

However, after discussion with other maintainers, we've decided against adding the opensauced link as it is to your employer, a private company which is currently mentioned in our CONTRIBUTING guide

Thank you for your PR and we welcome other changes that do not go against our CONTRIBUTING guide currently.

@jmeridth
Copy link
Member

Closing. Please refer to previous comment about our CONTRIBUTING.md guide and links to employer content.

Again, thank you for your PR and we welcome other changes that do not go against our CONTRIBUTING guide currently.

@jmeridth jmeridth closed this Jun 11, 2024
@CBID2 CBID2 deleted the adding-a-resource branch June 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants