Remove version lock from html-proofer #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been 2 major revs of HTML-Proofer since the one we pinned. The current one is causing flaky tests - it's missing clear errors w/internal links and only reports the first error it finds rather than running to completion and reporting all of them. The latest version (5.0.8 at the moment) does catch all of the errors but has a problem locally where UTF-8 encoded anchor links are not properly decoded. This might be a problem local to me though; I coded up a spec test in html-proofer with an exact copy-paste of one of the failing links and ... it passes there. So i'll unpin this and see if there's some local gem issue that's causing this on my machine and maybe it works in the Actions env.
based on html-proofer's UPGRADING.md , many of the old configuration directives have changed names in the new version.
tomthorogood
approved these changes
Apr 30, 2024
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been 2 major revs of HTML-Proofer since the one
we pinned. The current one is causing flaky tests - it's missing
clear errors w/internal links and only reports the first
error it finds rather than running to completion and reporting
all of them.
The latest version (5.0.8 at the moment) does catch all of the
errors but has a problem locally where UTF-8 encoded anchor links
are not properly decoded. This might be a problem local to me though;
I coded up a spec test in html-proofer with an exact copy-paste
of one of the failing links and ... it passes there.
So i'll unpin this and see if there's some local gem issue that's
causing this on my machine and maybe it works in the Actions env.