Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make the nav stick to the top of the pages #3210

Closed
wants to merge 1 commit into from

Conversation

MarwanBz
Copy link

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Enable Sticky Navigation Bar

Description:

This pull request introduces a sticky navigation bar to the Open Source Guide website. It implements the following:

  • Fixed positioning for the navigation bar, ensuring it remains visible at the top of the screen while scrolling.
  • This change improves user experience by providing easier access to navigation options throughout the website.

@jmeridth
Copy link
Member

jmeridth commented Apr 1, 2024

@MarwanBz could you please provide some screenshots? Thank you.

@MarwanBz MarwanBz changed the title feat: make the nav stick to the buttom of the pages feat: make the nav stick to the top of the pages Apr 1, 2024
@MarwanBz
Copy link
Author

MarwanBz commented Apr 1, 2024

Hey @jmeridth, yes sure
here is a video

sticky-nav.mp4

please check it out and let me what you think

@ahpook
Copy link
Contributor

ahpook commented Apr 3, 2024

Hi, thanks for the pull request but I don't think this is a change we'll take.

@ahpook ahpook closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants