-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create #3209
Create #3209
Conversation
Hi I don't understand why every time doing pull request it fails in the test part? |
…-for-open-source-maintainers.md,metrics.md, starting-a-project.md. And with this I finished translating everything
Hi , I finished translating everything. I ask to be checked and approved. Thank you in advance. |
I don't understand, because I need to git revert and --no-gpg-sign? |
Hi @BlueButterflies - you can ignore those comments as spam. Thank you for your contribution ❤️ Someone from our core team will review your contribution shortly and let you know if we have feedback. Thanks! |
Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BlueButterflies thank you so much for the translation. ❤️ I have a few questions.
Hey @BlueButterflies have you figured out what caused the GitHub Actions CI / tests to failed? |
@MarwanBz No . I think what error came from that I asked for revision of the code. It had happened to me for the first time and therefore I asked |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what is causing the tests to fail.
Added space that was suggested to me
…y.md according to the test errors
Hi guys, I finally managed to resolve the link connections, thanks also to your interventions. |
@BlueButterflies this looks good to me but want @ahpook to give final 👍 . Thank you for all your work and patience on this. |
Thank you |
@ahpook please accepts pull requests |
Hi, @jmeridth Sorry for the inconvenience, I'm wondering what to do with the pull requests in the open.guide repository in my account, since @ahpook linked everything to me. Because then I should make pull requests to the open-giude repository owned by github. |
@BlueButterflies there may be a bit more work needed. I'll confirm with @ahpook. Thank you again for your work and patience. |
Yep this LGTM - I reran tests locally with the updated HTML-Proofer and all the internal links work. Great work @BlueButterflies , thank you for responding to all the issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean checks w/html-proofer 5.0.8
Thank you for accepting my contribution Thank you in advance |
Oh damn, there is one more:
This is at line 500 in how-to-contribute.md |
Sorry! I did not understand the question before. I looked at these PRs : https://github.com/BlueButterflies/opensource.guide/pulls They are both spam from fake accounts :( so you can just close them. |
Thank you |
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction of link and some untranslated sentences in the how-to-contribute file found by @ahpook
I had to fix one small thing in the data structure in #3215 but this is now live on the site! Thank you @BlueButterflies for all your work on this 💯 |
|
Greetings,
I followed the instructions as written in the instructions to be able to contribute to the translation.
I decided to contribute to the translation of the project into the Bulgarian language, so people who don't know any languages other than Bulgarian can read your valuable advice on collaborating on open source projects.
Thank you in advance