Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclusion for reddit and updating contribution markdown. #3185

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

chrishalbert
Copy link
Contributor

@chrishalbert chrishalbert commented Dec 27, 2023

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

The current build is failing for html proofer on the reddit links. At first I thought this was due to https, but realized this was likely being blocked after subsequent automated requests from the same ip.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


@chrishalbert chrishalbert requested a review from a team as a code owner December 27, 2023 21:48
@chrishalbert chrishalbert force-pushed the bug/html-proof-reddit-errors branch from 93d9301 to 0108ff1 Compare December 27, 2023 23:35
@chrishalbert chrishalbert changed the title Use https. Add exclusion for reddit and updating contribution markdown. Dec 27, 2023
Copy link

@LuMocke LuMocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gut

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you - I saw those 403s from Reddit but didn't spend the time to track them down.

@ahpook ahpook merged commit e77a81a into github:main Jan 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants