Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-hans]optimized some statements to make them smoother #3174

Merged
merged 2 commits into from
Dec 6, 2023
Merged

[zh-hans]optimized some statements to make them smoother #3174

merged 2 commits into from
Dec 6, 2023

Conversation

sunny0826
Copy link
Contributor

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@sunny0826 sunny0826 requested a review from a team as a code owner November 30, 2023 10:05
@sunny0826
Copy link
Contributor Author

From the logs, it looks like the CI failure here was not caused by what I commit.

ahpook
ahpook approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the improvements!

@ahpook
Copy link
Contributor

ahpook commented Nov 30, 2023

Yes that test failure is unrelated.

@ahpook ahpook merged commit be43619 into github:main Dec 6, 2023
2 of 3 checks passed
@sunny0826 sunny0826 deleted the fix/zh-hans-legal branch December 7, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahpook ahpook ahpook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunny0826 @ahpook