Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation Article section into Urdu. #3166

Closed
wants to merge 12 commits into from
Closed

Conversation

Areebey
Copy link

@Areebey Areebey commented Oct 29, 2023

  • [Yes] Have you followed the contributing guidelines?
  • [Yes] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

I have to convert the article section into Urdu language kindly check it out.

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

We also need a _data/ur.yml file that contains the metadata for the language, please make a copy of the _data/en.yml file and change the field values to be correct for the new language. This is Step 4 at https://github.com/github/opensource.guide/blob/main/docs/translations.md#starting-a-translation

Also there are numerous test failures due to markdown style problems. Please review these and fix : https://github.com/github/opensource.guide/actions/runs/6686056224/job/18165010981?pr=3166

@Areebey
Copy link
Author

Areebey commented Nov 4, 2023

Sure, I can fix it asap.

Copy link

github-actions bot commented Dec 5, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 5, 2023
@ahpook
Copy link
Contributor

ahpook commented Dec 6, 2023

Hi, are you still interested in working on this? If so, please

  • rebase to main to get fixes for the failing tests
  • add the requested file with metadata for Urdu.

Thank you for the contribution!

@github-actions github-actions bot removed the stale label Dec 7, 2023
Copy link

github-actions bot commented Jan 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 7, 2024
@github-actions github-actions bot closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants