-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vietnamese language into locales folder #3157
Conversation
cbleduytan
commented
Oct 23, 2023
- Hi, I'm Tan (Niu), I'm from Vietnam. I just added a new language by Vietnamese. Please, can anyone review through my first task and merge it for me?
Thank you for working on this! It will be good to have a Vietnamese translation. However, it will not work without a matching Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first step but it also needs a language directory for the site to work, see my comment for more details.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@cbleduytan Hi, are you still interested in making this contribution? I left a review with some requested changes - Please take a look, I'd love to get this merged in! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_data/locales/vn.yml
I'm going to close this for inactivity, if someone wants to pick it up and carry forward with some translations that'd be awesome. |