Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vietnamese language into locales folder #3157

Closed
wants to merge 2 commits into from

Conversation

cbleduytan
Copy link

  • Hi, I'm Tan (Niu), I'm from Vietnam. I just added a new language by Vietnamese. Please, can anyone review through my first task and merge it for me?

@cbleduytan cbleduytan requested a review from a team as a code owner October 23, 2023 10:27
@ahpook
Copy link
Contributor

ahpook commented Nov 3, 2023

Thank you for working on this! It will be good to have a Vietnamese translation.

However, it will not work without a matching _articles/vn directory though. Can you please add that directory with a copy of all the articles, even if they are not translated yet? This is steps 5, 6 and 7 in the docs https://github.com/github/opensource.guide/blob/main/docs/translations.md#starting-a-translation

Thanks!

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first step but it also needs a language directory for the site to work, see my comment for more details.

Copy link

github-actions bot commented Dec 4, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Dec 4, 2023
@ahpook
Copy link
Contributor

ahpook commented Dec 6, 2023

@cbleduytan Hi, are you still interested in making this contribution? I left a review with some requested changes - Please take a look, I'd love to get this merged in!

Copy link

github-actions bot commented Jan 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Jan 6, 2024
@Avalir1996
Copy link

Copy link

@gavatron90 gavatron90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_data/locales/vn.yml

@ahpook
Copy link
Contributor

ahpook commented Feb 7, 2024

I'm going to close this for inactivity, if someone wants to pick it up and carry forward with some translations that'd be awesome.

@ahpook ahpook closed this Feb 7, 2024
@github github locked as spam and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants