Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go modules #934

Closed
wants to merge 3 commits into from
Closed

Add go modules #934

wants to merge 3 commits into from

Conversation

timvaillancourt
Copy link
Collaborator

Description

This is a merge PR of the user-submitted PR: #932

Unfortunately this step is required as our gh-ost testing won't run on external forks

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

cc @natewernimont-wk / @shlomi-noach

@timvaillancourt
Copy link
Collaborator Author

Replacing with #935 because our build system doesn't like the / in the branch name

@timvaillancourt timvaillancourt deleted the nw/add-go-mod branch May 7, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants