Java: Deprecate or remove imports of dataflow library copies #15026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egregius313
force-pushed
the
egregius313/java/dataflow/deprecate-old-dataflow-module-uses
branch
from
e7a79b4 to
aebbc7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the public re-exporting of the copies of the old dataflow library (e.g.
semmle.code.java.dataflow.DataFlow2orsemmle.code.java.dataflow.TaintTracking3).Currently CodeQL issues a warning when using an item from a
deprecated import, even if the usage is in a deprecated context. So for now, modules which still use the deprecated items (e.g. a deprecated class extendingTaintTracking2::Configuration) mark the import as deprecated, and then re-import it privately.