Formatting

src/start-proxy.test.ts

@@ -82,29 +82,34 @@ test("getCredentials returns all credentials when no language specified", async
 });
 
 test("getCredentials throws an error when non-printable characters are used", async (t) => {
-    const invalidCredentials = [
-      { type: "nuget_feed", host: "1nuget.pkg.github.com", token: "abc\u0000" }, // Non-printable character in token
-      { type: "nuget_feed", host: "2nuget.pkg.github.com\u0001" }, // Non-printable character in host
-      { type: "nuget_feed", host: "3nuget.pkg.github.com", password: "ghi\u0002" }, // Non-printable character in password
-      { type: "nuget_feed", host: "4nuget.pkg.github.com", password: "ghi\x00" }, // Non-printable character in password
-    ];
+  const invalidCredentials = [
+    { type: "nuget_feed", host: "1nuget.pkg.github.com", token: "abc\u0000" }, // Non-printable character in token
+    { type: "nuget_feed", host: "2nuget.pkg.github.com\u0001" }, // Non-printable character in host
+    {
+      type: "nuget_feed",
+      host: "3nuget.pkg.github.com",
+      password: "ghi\u0002",
+    }, // Non-printable character in password
+    { type: "nuget_feed", host: "4nuget.pkg.github.com", password: "ghi\x00" }, // Non-printable character in password
+  ];
 
-    for (const invalidCredential of invalidCredentials) {
-      const credentialsInput = Buffer.from(
-        JSON.stringify([invalidCredential]),
-      ).toString("base64");
+  for (const invalidCredential of invalidCredentials) {
+    const credentialsInput = Buffer.from(
+      JSON.stringify([invalidCredential]),
+    ).toString("base64");
 
-      t.throws(
-        () =>
-          startProxyExports.getCredentials(
-            getRunnerLogger(true),
-            undefined,
-            credentialsInput,
-            undefined,
-          ),
-        {
-          message: "Invalid credentials - fields must contain only printable characters",
-        },
-      );
-    }
-  });
+    t.throws(
+      () =>
+        startProxyExports.getCredentials(
+          getRunnerLogger(true),
+          undefined,
+          credentialsInput,
+          undefined,
+        ),
+      {
+        message:
+          "Invalid credentials - fields must contain only printable characters",
+      },
+    );
+  }
+});

src/start-proxy.ts

@@ -54,13 +54,13 @@ export function getCredentials(
   let parsed: Credential[];
   try {
     parsed = JSON.parse(credentialsStr) as Credential[];
-  } catch (error) {
+  } catch {
     // Don't log the error since it might contain sensitive information.
     logger.error("Failed to parse the credentials data.");
     throw new Error("Invalid credentials format.");
   }
 
-  let out: Credential[] = [];
+  const out: Credential[] = [];
   for (const e of parsed) {
     if (e.url === undefined && e.host === undefined) {
       // The proxy needs one of these to work. If both are defined, the url has the precedence.
@@ -73,13 +73,21 @@ export function getCredentials(
       continue;
     }
 
-
     const isPrintable = (str: string | undefined): boolean => {
       return str ? /^[\x20-\x7E]*$/.test(str) : true;
     };
 
-    if (!isPrintable(e.type) || !isPrintable(e.host) || !isPrintable(e.url) || !isPrintable(e.username) || !isPrintable(e.password) || !isPrintable(e.token)) {
-      throw new Error("Invalid credentials - fields must contain only printable characters");
+    if (
+      !isPrintable(e.type) ||
+      !isPrintable(e.host) ||
+      !isPrintable(e.url) ||
+      !isPrintable(e.username) ||
+      !isPrintable(e.password) ||
+      !isPrintable(e.token)
+    ) {
+      throw new Error(
+        "Invalid credentials - fields must contain only printable characters",
+      );
     }
 
     out.push({