Use AST parser to validate alt text - markdown-lint #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kendallgassner
commented
Oct 4, 2023
kendallgassner
commented
Oct 4, 2023
kendallgassner
commented
Oct 4, 2023
This was referenced Oct 4, 2023
khiga8
reviewed
Oct 11, 2023
action.yml
Outdated
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Runs alt text check and adds comment | ||
| run: | | ||
| source ${{ github.action_path }}/flag-alt-text.sh | ||
| source ${{ github.action_path }}/queries.sh | ||
| source ${{ github.action_path }}/flag-alt-text.sh |
There was a problem hiding this comment.
Looks like we can delete this given the file has been removed!
There was a problem hiding this comment.
I am testing this branch in one of my repos! (Related workflow error)
src/index.test.js
Outdated
| @@ -0,0 +1,127 @@ | |||
| import { validate } from "./validate.js"; | |||
| elif [[ $type = discussion_description ]]; then | ||
| addDiscussionComment $discussion_node_id "$message" | ||
| elif [[ $type = discussion_comment ]]; then | ||
| addDiscussionComment $discussion_node_id "$message" $reply_to_id |
There was a problem hiding this comment.
I would love if we can eventually move all of this bash logic into a well-tested node script! Out of scope here though :)
kendallgassner
commented
Oct 11, 2023
kendallgassner
commented
Oct 11, 2023
|
Proof of concept run: khiga8/link-checker#9 @khiga8 ... i had to check in node_modules..... but it works |
|
Eeep sorry I didn't get to review this today, I'll take a look first thing tomorrow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #30
I updated the alt-text-bot to use an AST (markdown-lint) to parse images for bad alt text. Using an AST allows us to ignore any images defined in code blocks.
Why is this cool