user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/for/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/for">@for /F "tokens=4 delims=.[XP " %%i IN ('ver') DO @set ver=%%i @if 10 LEQ %ver% @... However, that code has numerous problems: - `ver` listing varies between major Windows releases (though Git for Windows' support for these has most likely phased out already) and may not necessarily yield the same amount of tokens, thus it's better to perform a two-step tokenization - string, *then* version - while the output of `ver` hasn't been found to contain 'poisonous' Batch characters (e.g. <>|&), it's preferred to wrap it in double quotes to prevent the contents 'escaping' into another command and use `~` during assignment should it contain double quotes itself - the code won't run if `ver` encounters an error, yielding an empty variable **or** inheriting a value from the environment the script happened to be running in, introducing potential security issues - numeric comparison will fail should `ver` contain an empty string, thus the variable needs to be pre-initialized with a numeric value - a number as the left operand obscures error messages from `if` This can result in the following, rather cryptic error: Line 3444: Unable to run post-install scripts: C:\Program Files\Git> @if 10 LEQ @( Echoed due to `%ver%` being empty because of the problems listed above. Fixes git-for-windows/git#1585 and git-for-windows/git#4019; maybe more. Signed-off-by: Mateusz Kazimierczuk <mataha@users.noreply.github.com>

Commits

Commits on Jun 19, 2023

Parse Windows' version correctly in post-install script