Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for browser version #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improvements for browser version #6

wants to merge 2 commits into from

Conversation

phonezawphyo
Copy link

@phonezawphyo phonezawphyo commented May 25, 2018 •
edited
Loading

  • Added webpack to package dist file.
  • Moved vignette to a separate file to make index.js cleaner
  • Added support for canvas as source image for browser.
  • Disabled debug logs for browser.

@phonezawphyo
[fix]improved promise execution
f632f8b 
[rmv]vignette setting hardcoding
@isdampe
Copy link

isdampe commented Oct 24, 2018

+1 for merge on this.

@nhaberl
Copy link

nhaberl commented Nov 5, 2018

Would be great to see this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gladwinbobby gladwinbobby gladwinbobby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phonezawphyo @isdampe @nhaberl @gladwinbobby