chore(brevo): remove contact informations update logic #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasabrn
changed the title
madjid-asa
force-pushed
the
nicolasabrn/remove-unused-method
branch
from
8dad6ea to
a2780ba
Compare
madjid-asa
force-pushed
the
nicolasabrn/remove-contact-update
branch
from
bc0a84b to
512740f
Compare
nicolasabrn
force-pushed
the
nicolasabrn/remove-unused-method
branch
from
a2780ba to
ae6ccd8
Compare
nicolasabrn
force-pushed
the
nicolasabrn/remove-contact-update
branch
from
512740f to
f1722ac
Compare
nicolasabrn
force-pushed
the
nicolasabrn/remove-unused-method
branch
from
ae6ccd8 to
52ef8f7
Compare
nicolasabrn
force-pushed
the
nicolasabrn/remove-contact-update
branch
from
f1722ac to
180204c
Compare
github-actions
bot
requested review from
chloend,
Guilouf,
madjid-asa and
SebastienReuiller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Dans le contexte de l'amélioration de la synchronisation de la plateforme et de Brevo (CRM).
Afin de réduire le nombre de dépendances, je retire la méthode de mise à jour de contacts
update_contact()Je modifie les tests pour que ceux-ci testent (et mockent) directement la fonction
update_contact_email_blacklistedpour éviter une confusion éventuelle.Pourquoi ?
N/A
Comment ?
N/A
Captures d'écran (optionnel)
N/A
Autre (optionnel)
N/A