feat: factorisation d'un copié-collé #1640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
chloend,
madjid-asa and
SebastienReuiller
SebastienReuiller
requested changes
Jan 23, 2025
| # call api is in qpv | ||
| result_is_in_qpv = self.is_in_target(siae.latitude, siae.longitude, client=self.CLIENT) | ||
| self.success_count["etablissement"] += 1 | ||
| siae.is_qpv = result_is_in_qpv[self.IS_TAGET_KEY] |
There was a problem hiding this comment.
ça ne fonctionne pas ici, quand c'est pour la commande ZRR, c'est les champs ZRR de la siae qui doivent être mis à jour ("siae.is_zrr", "api_zrr_last_sync_date", zzr_code, zrr_name)
madjid-asa
force-pushed
the
guilouf/429-2many
branch
from
cbd1899 to
38cc012
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Guilouf
force-pushed
the
guilouf/429-2many
branch
2 times, most recently
from
3c3d240 to
8662a4a
Compare
Guilouf
force-pushed
the
guilouf/429-2many
branch
from
8662a4a to
ecfda6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Au départ c'était pour investiguer un bug sentry: https://inclusion.sentry.io/issues/13810452/?project=4508410616348752&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&statsPeriod=7d&stream_index=2
avant une éventuelle correction il fallait factoriser le code
Pourquoi ?
Le code était dupliqué entre les 2 commandes
Comment ?
Factoriser le code. L'issue sentry est probablement lié à un paramétrage de
batch_size, mais pas directement lié au codeTODO