remove complicated and useless frontend env variable management

.dockerignore

@@ -5,7 +5,6 @@ back/node_modules
 front/node_modules
 
 nginx/etc/letsencrypt
-front/env-config.js
 front/dist
 front/dist-ssr
 .env

Dockerfile.front

@@ -6,5 +6,4 @@ COPY ./front/ /app/front
 COPY ./back/src/shared /app/back/src/shared
 RUN npm run copy-shared
 RUN npm run build-with-shared-as-is
-RUN npm run prod-env-config
 CMD npm run serve -- --host 0.0.0.0

back/src/__tests__/e2e/addFormEstablishment.e2e.test.ts

@@ -32,9 +32,7 @@ describe("Route to post addEstablishmentFormRouteWithoutApiKey", () => {
       it("forbids access to route if no api consumer", async () => {
         const { request } = await buildTestApp();
 
-        const response = await request
-          .post(`/immersion-offers`)
-          .send({});
+        const response = await request.post(`/immersion-offers`).send({});
 
         expect(response.status).toBe(403);
       });

front/.dockerignore

@@ -1,5 +1,4 @@
 node_modules
-env-config.js
 .DS_Store
 dist
 dist-ssr

front/.gitignore

@@ -5,5 +5,3 @@ dist-ssr
 *.local
 .idea
 src/shared
-env-config.js
-!.env

front/package.json

@@ -2,16 +2,14 @@
   "version": "0.0.0",
   "scripts": {
     "test": "npm run symlink-or-copy-shared && jest --passWithNoTests",
-    "dev": "npm run symlink-shared && npm run gen-env-config && vite",
-    "dev-http": "npm run symlink-shared && GATEWAY=HTTP npm run gen-env-config && vite",
+    "dev": "npm run symlink-shared && VITE_GATEWAY=IN_MEMORY vite",
+    "dev-http": "npm run symlink-shared && vite",
     "build": "npm run symlink-or-copy-shared && vite build",
     "build-with-shared-as-is": "vite build",
-    "serve": "npm run prod-env-config && vite preview",
+    "serve": "vite preview",
     "typecheck": "tsc --noEmit",
     "includecheck": "./check_includes.sh",
     "format": "prettier --write src",
-    "gen-env-config": "chmod +x ./env.sh && ./env.sh",
-    "prod-env-config": "npm run gen-env-config && cp env-config.js dist/env-config.js",
     "format:check": "prettier --check src",
     "fullcheck": "npm run includecheck && npm run format && npm run test && npm run typecheck",
     "symlink-or-copy-shared": "if [ ! -z $CI ]; then npm run copy-shared; else npm run symlink-shared; fi;",

front/src/app/dependencies.ts

@@ -22,36 +22,36 @@ import { RomeAutocompleteGateway } from "src/core-logic/ports/RomeAutocompleteGa
 import { ENV } from "src/environmentVariables";
 
 export const formEstablishmentGateway: FormEstablishmentGateway =
-  ENV.gateway === "HTTP"
-    ? new HttpFormEstablishmentGateway()
-    : new InMemoryFormEstablishmentGateway(["12345678901238"]);
+  ENV.gateway === "IN_MEMORY"
+    ? new InMemoryFormEstablishmentGateway(["12345678901238"])
+    : new HttpFormEstablishmentGateway();
 
 export const immersionApplicationGateway: ImmersionApplicationGateway =
-  ENV.gateway === "HTTP"
-    ? new HttpImmersionApplicationGateway()
-    : new InMemoryImmersionApplicationGateway();
+  ENV.gateway === "IN_MEMORY"
+    ? new InMemoryImmersionApplicationGateway()
+    : new HttpImmersionApplicationGateway();
 
 export const immersionSearchGateway: ImmersionSearchGateway =
-  ENV.gateway === "HTTP"
-    ? new HttpImmersionSearchGateway()
-    : new InMemoryImmersionSearchGateway();
+  ENV.gateway === "IN_MEMORY"
+    ? new InMemoryImmersionSearchGateway()
+    : new HttpImmersionSearchGateway();
 
 export const apiAdresseGateway: ApiAdresseGateway =
-  ENV.gateway === "HTTP"
-    ? new HttpApiAdresseGateway()
-    : new InMemoryApiAdresseGateway();
+  ENV.gateway === "IN_MEMORY"
+    ? new InMemoryApiAdresseGateway()
+    : new HttpApiAdresseGateway();
 
 export const featureFlagsGateway: FeatureFlagsGateway =
-  ENV.gateway === "HTTP"
-    ? new HttpFeatureFlagGateway()
-    : new InMemoryFeatureFlagGateway();
+  ENV.gateway === "IN_MEMORY"
+    ? new InMemoryFeatureFlagGateway()
+    : new HttpFeatureFlagGateway();
 
 export const agencyGateway: AgencyGateway =
-  ENV.gateway === "HTTP"
-    ? new HttpAgencyGateway()
-    : new InMemoryAgencyGateway();
+  ENV.gateway === "IN_MEMORY"
+    ? new InMemoryAgencyGateway()
+    : new HttpAgencyGateway();
 
 export const romeAutocompleteGateway: RomeAutocompleteGateway =
-  ENV.gateway === "HTTP"
-    ? new HttpRomeAutocompleteGateway()
-    : new InMemoryRomeAutocompleteGateway();
+  ENV.gateway === "IN_MEMORY"
+    ? new InMemoryRomeAutocompleteGateway()
+    : new HttpRomeAutocompleteGateway();

front/src/environmentVariables.ts

@@ -1,12 +1,7 @@
-import { throwIfNotInArray } from "src/shared/envHelpers";
+const gateway =
+  import.meta.env.VITE_GATEWAY === "IN_MEMORY" ? "IN_MEMORY" : "HTTP";
 
-const windowEnv = (window as any)._env_;
-
-const gateway = throwIfNotInArray({
-  processEnv: windowEnv,
-  authorizedValues: ["HTTP", "IN_MEMORY"],
-  variableName: "GATEWAY",
-});
+console.info("Gateway is : ", gateway);
 
 export const ENV = {
   dev: import.meta.env.DEV,