Fix physical domain for benchmark stencils #1772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implies that the process subdomains will not be square/cube shaped anymore. Instead, they can have arbitrary shape `d_x * d_y (* d_z)`. The values `d_x, d_y, d_z` are process dependent, but they differ by at most 1 each.
ginkgo-bot
added
reg:testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the stencil generation for the benchmarks to always use the fixed physical domain$[0, 1]^d$ . Before, the domain was scaling with the number of processes, as each process subdomain had to be a square/cube. Now, the shape of the subdomains (as in their number of degrees of freedom per dimension) is not square/cubic anymore, and can differ (slightly) between processes.
The subdomain sizes are chosen such that:
Example: Consider a 2D equidistant grid with 81 DOFs in each direction. Given 2x2 processes, then the process at
[0, 0]will have41 x 41DOFs, and the process[1, 0]will have40 x 41DOFs.As a consequence of the variable subdomain size, the computed process local sizes have to be propagated up from the stencil creation.