Add sized ctor and public add_operator to Combination #1771
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ginkgo team is proud to announce the new Ginkgo minor release 1.9.0. This release brings new features such as: - Support for half precision (IEEE FP16). The type `gko::half` can now be selected in most instances as the value type of a matrix, solver, preconditioner, etc. If the selected backend supports FP16 as a native type, the native type is used within the kernels, otherwise an overhead might occur. The new behavior is enabled by default, but it can be turned off during configuration. - New implementations of the ILU and IC factorization for CUDA, HIP, OpenMP, and Reference backends. These are available in addition to the existing implementations based on the vendor libraries cuSPARSE and hipSPARSE. - New (S)SOR and Gauss-Seidel preconditioners. - Simplifyied distributed matrix assembly by exchanging local rows between neighboring processes. And more! See [the Changelog](./CHANGELOG.md) for more information.
|
Can you describe a use case for this? Combination creation is pretty lightweight, so I am hesitant to add more complexity there. |
greole
force-pushed
the
ogl_0600_gko190
branch
from
37353b3 to
1435c66
Compare
|
Sure and maybe there is a better way to do it. On the OGL side I have but there are cases (after repartitioning) where |
|
Making the empty case work seems sensible, except for the fact that we don't have anything to base the size on then. BTW ctr is kind of a misleading abbreviation, it could be counter or constructor. |
greole
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
Combination::add_operatorsmember public so that operators can be added after constructing a combination matrix. Additionally, a new constructor is added so that an empty combination can be created first and additional operators are added later.