Add 3D tutorial #27
Merged
Add 3D tutorial #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrygerardmoore
force-pushed
the
upstream_3d_tutorial
branch
from
22951f2 to
75e0320
Compare
henrygerardmoore
force-pushed
the
upstream_3d_tutorial
branch
from
75e0320 to
9e9ef55
Compare
|
Hi! Thank you very much, I applied your changes on my branch and I can build everything fine and run the 3d tutorial. If you are good with it, I will merge this PR. |
|
Yes, feel free to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here is the 3D tutorial I mentioned. I am operating off of PickNikRobotics/fuse:merge_3d_models, which is your 3D PR merged with the latest fuse changes. Since your branch isn't up to date with latest rolling, I can't build it, but on our branch this tutorial works. I tried to include descriptive comments, too, but please feel free to request changes with more descriptions or anything like that.
Screencast.from.09-27-2024.02.19.26.PM.webm
Again, thanks so much for undertaking this 3D model addition! It is super useful, and I hope this tutorial is a welcome addition.